Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 10933024: Accept raw strings prefixed by 'r' (issue 4815) (Closed)

Created:
8 years, 3 months ago by Brian Wilkerson
Modified:
8 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Accept raw strings prefixed by 'r' (issue 4815) Committed: https://code.google.com/p/dart/source/detail?r=12209

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartScanner.java View 1 chunk +7 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
8 years, 3 months ago (2012-09-11 15:31:20 UTC) #1
scheglov
LGTM, but I've expected to see test where we really check if parsed String is ...
8 years, 3 months ago (2012-09-11 16:11:52 UTC) #2
Brian Wilkerson
Done. PTAL.
8 years, 3 months ago (2012-09-11 16:22:52 UTC) #3
scheglov
8 years, 3 months ago (2012-09-11 16:37:15 UTC) #4
Thank you!

LGTM

Powered by Google App Engine
This is Rietveld 408576698