Issue 10928139: Changed interfaces to abstract classes where possible in {lib,samples,pkg}

Issue 10928139: Changed interfaces to abstract classes where possible in {lib,samples,pkg} (Closed)

Created:
8 years, 3 months ago by bakster

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changed interfaces to abstract classes where possible in {lib,samples,pkg} Committed: https://code.google.com/p/dart/source/detail?r=12255

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -118 lines)			Patch
M	lib/crypto/crypto.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/isolate/base.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/utf/utf_core.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	pkg/dartdoc/ast.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/dartdoc/mirrors/dart2js_mirror.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	pkg/dartdoc/mirrors/mirrors.dart	View	3 chunks	+79 lines, -79 lines	0 comments	Download
M	pkg/fixnum/intx.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/interfaces.dart	View	3 chunks	+3 lines, -3 lines	2 comments	Download
M	samples/markdown/ast.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	samples/swarm/Views.dart	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	samples/ui_lib/layout/SizingFunctions.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/ui_lib/layout/ViewLayout.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/ui_lib/observable/observable.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	samples/ui_lib/touch/Momentum.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/ui_lib/touch/ScrollWatcher.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/ui_lib/touch/TouchUtil.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/10928139/diff/1/lib/utf/utf_core.dart File lib/utf/utf_core.dart (right): https://chromiumcodereview.appspot.com/10928139/diff/1/lib/utf/utf_core.dart#newcode243 lib/utf/utf_core.dart:243: abstract class _ListRangeIterator extends Iterator<int> { Should that ...

8 years, 3 months ago (2012-09-12 10:41:47 UTC) #2

bakster

8 years, 3 months ago (2012-09-12 10:45:49 UTC) #3

Thanks

https://chromiumcodereview.appspot.com/10928139/diff/1/lib/utf/utf_core.dart
File lib/utf/utf_core.dart (right):

https://chromiumcodereview.appspot.com/10928139/diff/1/lib/utf/utf_core.dart#...
lib/utf/utf_core.dart:243: abstract class _ListRangeIterator extends
Iterator<int> {
On 2012/09/12 10:41:47, ngeoffray wrote:
> Should that be implements?

Done.

https://chromiumcodereview.appspot.com/10928139/diff/1/pkg/unittest/interface...
File pkg/unittest/interfaces.dart (right):

https://chromiumcodereview.appspot.com/10928139/diff/1/pkg/unittest/interface...
pkg/unittest/interfaces.dart:45: * [expect] Matchers must implement the Matcher
interface.
On 2012/09/12 10:41:47, ngeoffray wrote:
> Matcher interface -> Matcher class.

Done.

Expand Messages | Collapse Messages