Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10928121: Support new library/import syntax (Closed)

Created:
8 years, 3 months ago by hausner
Modified:
8 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support new library/import syntax This change simply adds new syntax support for the functionality we currently have in the VM. - Support for library and import, import-as. - Still to do: show/hide combinators, export, library parts. Committed: https://code.google.com/p/dart/source/detail?r=12216

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -35 lines) Patch
M runtime/vm/parser.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 5 chunks +128 lines, -12 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 10 chunks +54 lines, -20 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/prefix_new_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A tests/language/prefix_new_test1.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A tests/language/prefix_new_test2.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
Turns out that co19 is already using the new import syntax, so I could drop ...
8 years, 3 months ago (2012-09-11 18:45:02 UTC) #1
regis
LGTM http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status#newcode126 tests/co19/co19-runtime.status:126: How about removing instead of commenting out? http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status#newcode219 ...
8 years, 3 months ago (2012-09-11 19:11:26 UTC) #2
hausner
Thank you. http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status#newcode126 tests/co19/co19-runtime.status:126: On 2012/09/11 19:11:26, regis wrote: > How ...
8 years, 3 months ago (2012-09-11 20:04:07 UTC) #3
regis
8 years, 3 months ago (2012-09-11 20:53:08 UTC) #4
On 2012/09/11 20:04:07, hausner wrote:
> Thank you.
> 
> http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status
> File tests/co19/co19-runtime.status (right):
> 
>
http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status...
> tests/co19/co19-runtime.status:126: 
> On 2012/09/11 19:11:26, regis wrote:
> > How about removing instead of commenting out?
> 
> Done.
> 
>
http://codereview.chromium.org/10928121/diff/1/tests/co19/co19-runtime.status...
> tests/co19/co19-runtime.status:219: 
> On 2012/09/11 19:11:26, regis wrote:
> > What is the problem with the new failing tests above? I suppose it is
related
> to
> > your change? You should change the failure reason. 
> No these changes come in through the upgrade of co19, not as a result of my
> change. Yes, someone will have to triage them.

But your cl is not upgrading the co19 tests. I still do not understand why you
had to add these failures to your cl.

Powered by Google App Engine
This is Rietveld 408576698