Issue 10928071: Pub: fix the 'system_cache' library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10928071: Pub: fix the 'system_cache' library (Closed)

Created:
8 years, 3 months ago by Ladislav Thon

Modified:
8 years, 3 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Pub: fix the 'system_cache' library There were 2 small errors: 1. The Version class is used, but the 'version' library wasn't imported. 2. The arguments to the PackageId constructor were passed in wrong order. BUG= Committed: https://code.google.com/p/dart/source/detail?r=12147

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	utils/pub/system_cache.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ladislav Thon

Pub: fix the 'system_cache' library There were 2 small errors: 1. The Version class is ...

8 years, 3 months ago (2012-09-10 18:56:13 UTC) #1

LGTM, I'll go ahead and commit this

Expand Messages | Collapse Messages