Issue 10928057: Fix issue 4960 (getter syntax in html_enhanced_config).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10928057: Fix issue 4960 (getter syntax in html_enhanced_config). (Closed)

Created:
8 years, 3 months ago by gram

Modified:
8 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 80 column layout in html_enhanced_config. Committed: https://code.google.com/p/dart/source/detail?r=12050

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -14 lines)			Patch
	M	pkg/unittest/html_enhanced_config.dart	View	1	3 chunks	+26 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 3 months ago (2012-09-07 17:15:43 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10928057/diff/1/pkg/unittest/html_enha...
File pkg/unittest/html_enhanced_config.dart (right):

https://chromiumcodereview.appspot.com/10928057/diff/1/pkg/unittest/html_enha...
pkg/unittest/html_enhanced_config.dart:238: static bool get _isIE =>
document.window.navigator.userAgent.contains('MSIE');
while we are here, can you fix this to be 80 cols?

https://chromiumcodereview.appspot.com/10928057/diff/1/pkg/unittest/html_enha...
pkg/unittest/html_enhanced_config.dart:244: font-family: 'Open Sans', 'Lucida
Sans Unicode', 'Lucida Grande', sans-serif;
ditto

Expand Messages | Collapse Messages