Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10928051: Remove more () from getters. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove more () from getters. This makes it possible to run all standard tests except co19 without ever using a getter that's defined with (). R=iposva@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M runtime/lib/array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/lib/string_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 8 chunks +26 lines, -26 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/scanner_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 3 months ago (2012-09-07 12:13:41 UTC) #1
Ivan Posva
LGTM -ip
8 years, 3 months ago (2012-09-07 12:36:01 UTC) #2
hausner
8 years, 3 months ago (2012-09-07 15:24:08 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698