issue 4817 fixed. Implemented raw strings with 'r' instead of '@' for dart2js

issue 4817 fixed. Implemented raw strings with 'r' instead of '@' for dart2js

BUG=dart:4817
Committed: https://code.google.com/p/dart/source/detail?r=12292

[aam-me, 2012-09-11 01:22:09]

Please, review when you have a chance.

[ahe, 2012-09-11 06:04:34]

LGTM, but please don't submit until Brian and Matthias agree that we can make
this change now.

We have to coordinate three different implementations, the VM, the Editor, and
dart2js. Brian and Matthias should get a chance to object if this will cause
them problems now.

Since we support the old syntax and don't warn about it, I don't see how this
could be a problem, but still, Matthias and Brian should be involved.

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/scanner/scanner.dart (right):

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
lib/compiler/implementation/scanner/scanner.dart:628: int
tokenizeRawStringKeywordOrIdentifier(int next, bool allowDollar) {
allowDollar is always true. The parameter is not necessary.

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/string_validator.dart (right):

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
lib/compiler/implementation/string_validator.dart:52: // TODO(aprelev@gmail.com)
Remove deprecated "quoteChar === $AT ||" below
Add : after ). Terminate comment with period.

[hausner, 2012-09-11 16:27:06]

lgtm

[Brian Wilkerson, 2012-09-11 16:30:05]

LGTM

[aam-me, 2012-09-12 02:12:38]

Thank you, guys, for the reviews. 

Peter, all points were addressed. 

Can I help with getting change across components coordinated or it is happening
already and someone will ping me when it is time to commit dart2js bit?

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/scanner/scanner.dart (right):

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
lib/compiler/implementation/scanner/scanner.dart:628: int
tokenizeRawStringKeywordOrIdentifier(int next, bool allowDollar) {
On 2012/09/11 06:04:34, ahe wrote:
> allowDollar is always true. The parameter is not necessary.

Done.

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/string_validator.dart (right):

https://chromiumcodereview.appspot.com/10920066/diff/4001/lib/compiler/implem...
lib/compiler/implementation/string_validator.dart:52: // TODO(aprelev@gmail.com)
Remove deprecated "quoteChar === $AT ||" below
On 2012/09/11 06:04:34, ahe wrote:
> Add : after ). Terminate comment with period.

Done.

[Brian Wilkerson, 2012-09-12 13:19:42]

> Can I help with getting change across components coordinated or it is
happening
> already and someone will ping me when it is time to commit dart2js bit?

The new raw string syntax is already supported in Analyzer (dartc). I'm waiting
for this change and the VM change to start issuing a warning when the old syntax
is being used.

As long as this doesn't fail for the old syntax, there's no reason to wait to
commit it.

[ahe, 2012-09-13 17:22:59]

Awesome, thank you, Alexander!

Cheers,
Peter