Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10919239: Change Uri.fromComponents to take named optional arguments. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org, regis
Visibility:
Public.

Description

Change Uri.fromComponents to take named optional arguments. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -26 lines) Patch
M lib/uri/uri.dart View 2 chunks +22 lines, -15 lines 0 comments Download
M tests/utils/uri_test.dart View 3 chunks +39 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 3 months ago (2012-09-12 12:37:35 UTC) #1
Ivan Posva
LGTM -ip
8 years, 3 months ago (2012-09-12 12:56:34 UTC) #2
ahe
8 years, 3 months ago (2012-09-12 13:01:07 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698