Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10919136: Removing SelectElement.add method and adding a constructor. (Closed)

Created:
8 years, 3 months ago by blois
Modified:
8 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removing SelectElement.add method and adding a constructor. BUG=2583, 3947 Committed: https://code.google.com/p/dart/source/detail?r=12002

Patch Set 1 #

Patch Set 2 : Merging with latest bits.wq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M lib/dom/idl/dart/dart.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M tests/html/element_constructor_1_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
8 years, 3 months ago (2012-09-06 21:14:41 UTC) #1
vsm
8 years, 3 months ago (2012-09-06 21:28:15 UTC) #2
lgtm.  The dom*.dart will disappear when you sync though.

Powered by Google App Engine
This is Rietveld 408576698