Support for new 'export' directive in resolver

Support for new 'export' directive in resolver


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11984

[Brian Wilkerson, 2012-09-06 20:13:07]

LGTM with one minor change

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/LibraryNode.java (right):

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/LibraryNode.java:46: this.exported =
false;
I'm sure there's a reason, but it seems like "exported" ought to be "true".

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:451: while
(peekPseudoKeyword(0, EXPORT_KEYWORD)) {
Sorry I missed this change earlier. Actually, import and export directives can
be mixed in any order, so this loop needs to be merged with the previous loop.

[scheglov, 2012-09-06 20:28:22]

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/ast/LibraryNode.java (right):

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/ast/LibraryNode.java:46: this.exported =
false;
On 2012/09/06 20:13:07, Brian Wilkerson wrote:
> I'm sure there's a reason, but it seems like "exported" ought to be "true".

This field is not used for "export".

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10919133/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:451: while
(peekPseudoKeyword(0, EXPORT_KEYWORD)) {
On 2012/09/06 20:13:07, Brian Wilkerson wrote:
> Sorry I missed this change earlier. Actually, import and export directives can
> be mixed in any order, so this loop needs to be merged with the previous loop.

Done.

[ahe, 2012-10-19 08:29:18]

One could get the impression that this wasn't tested. There are no new tests
added to tests/language, no changes to language or co19 status files, and it
doesn't work (see http://dartbug.com/6073).

As far as I can tell, the only test of this CL is a negative test
(test_newLibrarySyntax_export in
dart/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java).