Issue 10919130: Reimplement SourceFile.getLine using binary search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919130: Reimplement SourceFile.getLine using binary search. (Closed)

Created:
8 years, 3 months ago by podivilov

Modified:
8 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reimplement SourceFile.getLine using binary search. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=12102

Patch Set 2 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	lib/compiler/implementation/source_file.dart	View	1	1 chunk	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10919130/diff/1/lib/compiler/implementation/source_file.dart File lib/compiler/implementation/source_file.dart (right): https://chromiumcodereview.appspot.com/10919130/diff/1/lib/compiler/implementation/source_file.dart#newcode50 lib/compiler/implementation/source_file.dart:50: int step = count >> 1; count ~/ ...

8 years, 3 months ago (2012-09-10 09:08:20 UTC) #3

podivilov

8 years, 3 months ago (2012-09-10 09:45:45 UTC) #4

https://chromiumcodereview.appspot.com/10919130/diff/1/lib/compiler/implement...
File lib/compiler/implementation/source_file.dart (right):

https://chromiumcodereview.appspot.com/10919130/diff/1/lib/compiler/implement...
lib/compiler/implementation/source_file.dart:50: int step = count >> 1;
On 2012/09/10 09:08:20, floitsch wrote:
> count ~/ 2

Done.

Expand Messages | Collapse Messages

Issue 10919130: Reimplement SourceFile.getLine using binary search. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages