Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10919123: Reapply Issue 10911006. (Closed)

Created:
8 years, 3 months ago by karlklose
Modified:
8 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply Issue 10911006. Most parts of this CL were already reviewed as https://chromiumcodereview.appspot.com/10911006/. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=11949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -59 lines) Patch
M lib/compiler/implementation/compiler.dart View 6 chunks +8 lines, -13 lines 0 comments Download
M lib/compiler/implementation/enqueue.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M lib/compiler/implementation/js_backend/backend.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M lib/compiler/implementation/js_backend/emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/js_backend/native_emitter.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/resolver.dart View 7 chunks +30 lines, -9 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 6 chunks +20 lines, -19 lines 0 comments Download
M lib/compiler/implementation/typechecker.dart View 8 chunks +63 lines, -4 lines 0 comments Download
M lib/compiler/implementation/universe.dart View 2 chunks +11 lines, -3 lines 0 comments Download
M lib/compiler/implementation/util/link.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/compiler/implementation/util/link_implementation.dart View 2 chunks +18 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karlklose
Florian, could you take a look at compiler.dart, js_backend/backend.dart and the compiler_helper.dart?
8 years, 3 months ago (2012-09-06 12:29:28 UTC) #1
floitsch
8 years, 3 months ago (2012-09-06 13:06:23 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698