Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 10919087: Change type of variable using assignment only if it was not explicitly declared (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change type of variable using assignment only if it was explicitly not declared R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 2 chunks +19 lines, -4 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-05 03:29:24 UTC) #1
Brian Wilkerson
8 years, 3 months ago (2012-09-05 03:44:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698