Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 10919039: The forward declaration of Dart_SetReturnValue in native_arguments.h (Closed)

Created:
8 years, 3 months ago by turnidge
Modified:
8 years, 3 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

The forward declaration of Dart_SetReturnValue in native_arguments.h was causing the function to appear to be ambiguous on windows due to the DART_EXTERN_C annotation. Refactor the code so that a different function is forward-declared in order to fix the build. Another fix would have been to prefix all calls to Dart_SetReturnValue by :: in lib/mirrors.cc, but that looks ugly. Committed: https://code.google.com/p/dart/source/detail?r=11719

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M vm/dart_api_impl.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M vm/native_arguments.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
turnidge
8 years, 3 months ago (2012-08-31 20:12:13 UTC) #1
TBR=iposva

I'm going to commit now to unwedge the build.  If you have comments, I will do a
follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698