Rework Unparser/unparse StringBuffer management.

Rework Unparser/unparse StringBuffer management.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=11750

[Roman, 2012-09-03 06:39:24]

lgtm

https://chromiumcodereview.appspot.com/10919033/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10919033/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/emitter.dart:24:
unparser.visit(variableList.parseNode(compiler));
Can you please make a function 'unparse' in Unparser that will just call
visit()?
Again it's a matter of client code vs implementation details. I can understand
"visit" when I'm inside Unparser, because I'm aware that it's a visitor. For
client the name 'visit' makes little sense, because it does not matter how
Unparser unparses code, whether it's a visitor or not.

[Anton Muhin, 2012-09-03 09:28:10]

https://chromiumcodereview.appspot.com/10919033/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10919033/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/emitter.dart:24:
unparser.visit(variableList.parseNode(compiler));
On 2012/09/03 06:39:24, Roman wrote:
> Can you please make a function 'unparse' in Unparser that will just call
> visit()?
> Again it's a matter of client code vs implementation details. I can understand
> "visit" when I'm inside Unparser, because I'm aware that it's a visitor. For
> client the name 'visit' makes little sense, because it does not matter how
> Unparser unparses code, whether it's a visitor or not.

Done.

[Roman, 2012-09-03 09:40:53]

lgtm

[ahe, 2012-09-18 13:29:18]

https://chromiumcodereview.appspot.com/10919033/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/tree/nodes.dart (left):

https://chromiumcodereview.appspot.com/10919033/diff/4001/lib/compiler/implem...
lib/compiler/implementation/tree/nodes.dart:117: } catch (e, trace) {
Why was this removed?

I'm looking at this stack trace right now:

<Received error while converting exception to string>
#0      Object._noSuchMethod (dart:core-patch:2496:3)
#1      Object.noSuchMethod (dart:core-patch:2493:18)
#2      Dart2JsLibraryMirror.simpleName
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:495:42)
#3      Dart2JsLibraryMirror.canonicalName
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:486:41)
#4      Dart2JsMirrorSystem._ensureLibraries.<anonymous closure>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:442:40)
#5      HashMapImplementation.forEach (bootstrap_impl:914:10)
#6      Dart2JsMirrorSystem._ensureLibraries
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:440:33)
#7      Dart2JsMirrorSystem.libraries
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:449:21)
#8      HtmlDiff.run
(file:///Users/ahe/Dart/all/dart/utils/apidoc/html_diff.dart:95:58)
#9      main (file:///Users/ahe/Dart/all/dart/utils/apidoc/apidoc.dart:85:12)

If this code had been in place, I would have the information I need to debug and
implement library syntax.

[Anton Muhin, 2012-09-19 09:38:42]

https://chromiumcodereview.appspot.com/10919033/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/tree/nodes.dart (left):

https://chromiumcodereview.appspot.com/10919033/diff/4001/lib/compiler/implem...
lib/compiler/implementation/tree/nodes.dart:117: } catch (e, trace) {
Sorry, I don't immediately see what's the problem: apparently there is no
exception thrown while unparsing.

On 2012/09/18 13:29:18, ahe wrote:
> Why was this removed?
> 
> I'm looking at this stack trace right now:
> 
> <Received error while converting exception to string>
> #0      Object._noSuchMethod (dart:core-patch:2496:3)
> #1      Object.noSuchMethod (dart:core-patch:2493:18)
> #2      Dart2JsLibraryMirror.simpleName
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:495:42)
> #3      Dart2JsLibraryMirror.canonicalName
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:486:41)
> #4      Dart2JsMirrorSystem._ensureLibraries.<anonymous closure>
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:442:40)
> #5      HashMapImplementation.forEach (bootstrap_impl:914:10)
> #6      Dart2JsMirrorSystem._ensureLibraries
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:440:33)
> #7      Dart2JsMirrorSystem.libraries
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:449:21)
> #8      HtmlDiff.run
> (file:///Users/ahe/Dart/all/dart/utils/apidoc/html_diff.dart:95:58)
> #9      main (file:///Users/ahe/Dart/all/dart/utils/apidoc/apidoc.dart:85:12)
> 
> If this code had been in place, I would have the information I need to debug
and
> implement library syntax.

[ahe, 2012-09-19 10:33:12]

https://chromiumcodereview.appspot.com/10919033/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/tree/nodes.dart (left):

https://chromiumcodereview.appspot.com/10919033/diff/4001/lib/compiler/implem...
lib/compiler/implementation/tree/nodes.dart:117: } catch (e, trace) {
On 2012/09/19 09:38:43, Anton Muhin wrote:
> Sorry, I don't immediately see what's the problem: apparently there is no
> exception thrown while unparsing.

The code is there to handle when something that isn't tested breaks. For
example, when we add a new subclass of Node.


> 
> On 2012/09/18 13:29:18, ahe wrote:
> > Why was this removed?
> > 
> > I'm looking at this stack trace right now:
> > 
> > <Received error while converting exception to string>
> > #0      Object._noSuchMethod (dart:core-patch:2496:3)
> > #1      Object.noSuchMethod (dart:core-patch:2493:18)
> > #2      Dart2JsLibraryMirror.simpleName
> >
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:495:42)
> > #3      Dart2JsLibraryMirror.canonicalName
> >
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:486:41)
> > #4      Dart2JsMirrorSystem._ensureLibraries.<anonymous closure>
> >
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:442:40)
> > #5      HashMapImplementation.forEach (bootstrap_impl:914:10)
> > #6      Dart2JsMirrorSystem._ensureLibraries
> >
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:440:33)
> > #7      Dart2JsMirrorSystem.libraries
> >
>
(file:///Users/ahe/Dart/all/dart/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:449:21)
> > #8      HtmlDiff.run
> > (file:///Users/ahe/Dart/all/dart/utils/apidoc/html_diff.dart:95:58)
> > #9      main
(file:///Users/ahe/Dart/all/dart/utils/apidoc/apidoc.dart:85:12)
> > 
> > If this code had been in place, I would have the information I need to debug
> and
> > implement library syntax.
>