Issue 10919005: Clear use lists for globals and definitions in start environment in release mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919005: Clear use lists for globals and definitions in start environment in release mode. (Closed)

Created:
8 years, 3 months ago by zerny-google

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clear use lists for globals and definitions in start environment in release mode. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=11613

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph.cc	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 3 months ago (2012-08-30 18:32:02 UTC) #3

DBC

https://chromiumcodereview.appspot.com/10919005/diff/1/runtime/vm/flow_graph.cc
File runtime/vm/flow_graph.cc (right):

https://chromiumcodereview.appspot.com/10919005/diff/1/runtime/vm/flow_graph....
runtime/vm/flow_graph.cc:288: for (intptr_t i = 0; i <
graph_entry_->start_env()->values().length(); ++i) {
You could cache  graph_entry_->start_env()->values() in a local variable.

Expand Messages | Collapse Messages