Issue 10919003: Fix issue with the partial type tree and implemented interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919003: Fix issue with the partial type tree and implemented interfaces. (Closed)

Created:
8 years, 3 months ago by kasperl

Modified:
8 years, 3 months ago

Reviewers:
Søren Gjesse, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix issue with the partial type tree and implemented interfaces. Treat partial type trees that have cross-links (because of implements) as too complex and use a slower, but correct way of walking them. R=sgjesse@google.com,ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11584

Patch Set 1 #

Patch Set 2 : Remove newline. #

Total comments: 1

Patch Set 3 : Fix comment. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -4 lines)			Patch
M	lib/compiler/implementation/js_backend/function_set.dart	View		2 chunks	+24 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/js_backend/partial_type_tree.dart	View	1 2	2 chunks	+49 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/js_backend/selector_map.dart	View	1	2 chunks	+28 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 3 months ago (2012-08-30 08:22:18 UTC) #3

LGTM!

https://chromiumcodereview.appspot.com/10919003/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/js_backend/partial_type_tree.dart (right):

https://chromiumcodereview.appspot.com/10919003/diff/3001/lib/compiler/implem...
lib/compiler/implementation/js_backend/partial_type_tree.dart:15: //
TODO(kasperl): For now, we keep track of whether not the tree
remove 'not'

Expand Messages | Collapse Messages