Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 10918188: Stop treating final as const in dart2js. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
Reviewers:
ngeoffray, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M lib/compiler/implementation/compile_time_constants.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/co19/co19-dart2js.status View 3 chunks +4 lines, -2 lines 0 comments Download
A + tests/language/final_is_not_const_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 3 months ago (2012-09-12 05:47:09 UTC) #1
Ivan Posva
LGTM -ip
8 years, 3 months ago (2012-09-12 06:11:57 UTC) #2
ngeoffray
8 years, 3 months ago (2012-09-12 06:34:32 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698