Issue 10918168: Run dart2js tests unmodified in drt.

Issue 10918168: Run dart2js tests unmodified in drt. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang), kasperl

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Run dart2js tests unmodified in drt. Committed: https://code.google.com/p/dart/source/detail?r=12182

Patch Set 2 : Only wrap on DRT #

Total comments: 1

Patch Set 3 : Review comments #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -21 lines)			Patch
M	dart/lib/compiler/implementation/js_backend/emitter.dart	View		3 chunks	+38 lines, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/lib/isolate_patch.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/pkg/unittest/config.dart	View		3 chunks	+14 lines, -3 lines	1 comment	Download
M	dart/pkg/unittest/test_controller.js	View		3 chunks	+44 lines, -7 lines	0 comments	Download
M	dart/tests/compiler/dart2js_native/dart2js_native.status	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1 2	3 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10918168/diff/2001/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10918168/diff/2001/dart/tools/testing/dart/test_suite.dart#newcode399 dart/tools/testing/dart/test_suite.dart:399: || configuration['runtime'] != 'drt'; 4 space indent?

8 years, 3 months ago (2012-09-11 11:12:15 UTC) #2

Siggi Cherem (dart-lang)

8 years, 3 months ago (2012-09-21 00:07:58 UTC) #3

https://chromiumcodereview.appspot.com/10918168/diff/1008/dart/pkg/unittest/c...
File dart/pkg/unittest/config.dart (right):

https://chromiumcodereview.appspot.com/10918168/diff/1008/dart/pkg/unittest/c...
dart/pkg/unittest/config.dart:149: print(message);
Hi Peter,

Would it be ok to move this logic to html_config?

Basically this file is meant to be platform independent, and it is used as a
base class to define html_config, vm_config, and so on. This change makes it
that we see noise print messages in command-line tests that are not running in
browsers.

I'm not sure I understand correctly how you are using this change, but I believe
moving things to html_config (which is the configuration being used when
wrapping tests to run them in drt) will keep things working for you as well.

Let us know,
Thanks
Siggi

Expand Messages | Collapse Messages