Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 10918163: Revert Expando changes. There are checked-mode errors that I need (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert Expando changes. There are checked-mode errors that I need to sort out. Revert "Patch expando directly in corelib instead of going through coreimpl." Revert "Fix merge error." R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -45 lines) Patch
M lib/compiler/implementation/lib/core_patch.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M lib/compiler/implementation/lib/coreimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/lib/coreimpl_patch.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M lib/core/expando.dart View 2 chunks +4 lines, -9 lines 0 comments Download
M lib/coreimpl/coreimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/coreimpl/corelib_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A lib/coreimpl/expando.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/lib/expando_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/lib_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/lib_sources.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698