Move lib/compiler to pkg/compiler in SDK

Move lib/compiler to pkg/compiler in SDK.

This addresses issue 4788 in the SDK. Once lib/compiler moves to pkg/compiler in the repo, this change can be undone.
Committed: https://code.google.com/p/dart/source/detail?r=12062

[ahe, 2012-09-06 20:46:48]

I'd appreciate if you didn't do this until dart2js lives in pkg/compiler.

[Emily Fortuna, 2012-09-06 20:55:36]

lgtm

[danrubel, 2012-09-06 21:49:41]

LGTM with a suggestion...

https://chromiumcodereview.appspot.com/10918106/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/10918106/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:248: [('"compiler/', '"../pkg/compiler/')])
If its not in the "lib" directory then it should not be in the "libraries.dart"
file

[dgrove, 2012-09-06 23:57:00]

On 2012/09/06 21:49:41, danrubel wrote:
> LGTM with a suggestion...
> 
> https://chromiumcodereview.appspot.com/10918106/diff/1/tools/create_sdk.py
> File tools/create_sdk.py (right):
> 
>
https://chromiumcodereview.appspot.com/10918106/diff/1/tools/create_sdk.py#ne...
> tools/create_sdk.py:248: [('"compiler/', '"../pkg/compiler/')])
> If its not in the "lib" directory then it should not be in the
"libraries.dart"
> file

What's really happening is that there are dart2js paths in libraries.dart, and
those are the things that need to be massaged. the top-level compiler directory
is already not in libraries.dart

[ahe, 2012-09-07 06:09:02]

LGTM

I give up. The properties I was trying to preserve were already lost.

I think it is problematic that we are not moving closer to having the same
layout in the repository and the SDK. As far as I'm concerned, create_sdk should
be:

cp -a lib out/.../dart-sdk/lib
cp -a pkg out/.../dart-sdk/pkg

I don't understand how this change brings us closer to that goal, or what
problem is solved by change.

I'm not sure how all the import rewriting will interact with snapshots. We may
also have to create snapshots from create_sdk. 

I recommend that you test this using the Basic test recommendation found here:
http://code.google.com/p/dart/wiki/TestingDart2js

But add the option --use-sdk to test.py.

[dgrove, 2012-09-07 20:20:19]

Emily - PTAL before I commit this. dartdoc also needed some fixup.

On 2012/09/07 06:09:02, ahe wrote:
> LGTM
> 
> I give up. The properties I was trying to preserve were already lost.
> 
> I think it is problematic that we are not moving closer to having the same
> layout in the repository and the SDK. As far as I'm concerned, create_sdk
should
> be:
> 
> cp -a lib out/.../dart-sdk/lib
> cp -a pkg out/.../dart-sdk/pkg
> 
> I don't understand how this change brings us closer to that goal, or what
> problem is solved by change.
> 
> I'm not sure how all the import rewriting will interact with snapshots. We may
> also have to create snapshots from create_sdk. 
> 
> I recommend that you test this using the Basic test recommendation found here:
> http://code.google.com/p/dart/wiki/TestingDart2js
> 
> But add the option --use-sdk to test.py.

[Emily Fortuna, 2012-09-07 20:31:10]

lgtm with comments

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:41: #.......htmlescape/
are we no longer going to have a web/net-type directory?

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:122: [(r'\$BIN_DIR/\.\./\.\./lib', r'$BIN_DIR/../pkg')])
backslashes not needed because this is a raw string. backslashes only make it
less readable.

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:242: # TODO(dgrove): remove this once issue 4788 is
addressed.
Nit: comments start with capital letter: "Remove"

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:274: 
unnecessary whitespace

[dgrove, 2012-09-07 20:35:33]

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:41: #.......htmlescape/
On 2012/09/07 20:31:10, Emily Fortuna wrote:
> are we no longer going to have a web/net-type directory?

This moved in the repo last night.

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:122: [(r'\$BIN_DIR/\.\./\.\./lib', r'$BIN_DIR/../pkg')])
On 2012/09/07 20:31:10, Emily Fortuna wrote:
> backslashes not needed because this is a raw string. backslashes only make it
> less readable.

Done.

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:242: # TODO(dgrove): remove this once issue 4788 is
addressed.
On 2012/09/07 20:31:10, Emily Fortuna wrote:
> Nit: comments start with capital letter: "Remove"

Done.

https://chromiumcodereview.appspot.com/10918106/diff/6002/tools/create_sdk.py...
tools/create_sdk.py:274: 
On 2012/09/07 20:31:10, Emily Fortuna wrote:
> unnecessary whitespace

Done.