Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 10918063: Remove dom_deprecated from everywhere but lib/dom and lib/html (Closed)

Created:
8 years, 3 months ago by Emily Fortuna
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, compiler-dev_dartlang.org, vsm, pquitslund
Visibility:
Public.

Description

Remove dom_deprecated from everywhere but lib/dom and lib/html. Committed: https://code.google.com/p/dart/source/detail?r=11908

Patch Set 1 : #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -244 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M lib/_internal/libraries.dart View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M utils/apidoc/apidoc.dart View 1 2 5 chunks +19 lines, -13 lines 0 comments Download
M utils/apidoc/html_diff.dart View 1 2 9 chunks +42 lines, -99 lines 0 comments Download
D utils/apidoc/html_diff_dump.dart View 1 2 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Emily Fortuna
This removes dom_deprecated from utils/apidoc, which then allows us to remove it from everywhere else ...
8 years, 3 months ago (2012-09-05 18:43:42 UTC) #1
eub
I'm still not an apidoc expert, but it looks good to me, if it works ...
8 years, 3 months ago (2012-09-05 21:28:11 UTC) #2
Emily Fortuna
ptal. Added suggestions. The output of linking MDN to docs seems to be the same ...
8 years, 3 months ago (2012-09-05 21:57:26 UTC) #3
Emily Fortuna
+ Keerthi for looking at change in editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java
8 years, 3 months ago (2012-09-05 22:07:40 UTC) #4
keertip
lgtm - editor changes look fine
8 years, 3 months ago (2012-09-05 22:10:22 UTC) #5
pquitslund
LGTM. From my end, looks awesome.
8 years, 3 months ago (2012-09-05 22:20:53 UTC) #6
Johnni Winther
8 years, 3 months ago (2012-09-06 07:59:36 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698