Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 10918061: Fixed test in checked mode. (Closed)

Created:
8 years, 3 months ago by Tom Ball
Modified:
8 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fixed test in checked mode. Committed: https://code.google.com/p/dart/source/detail?r=11846

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/tests/vm/dart/assert_with_type_test_or_cast_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Ball
Fixed cast in new test.
8 years, 3 months ago (2012-09-04 21:54:43 UTC) #1
Tom Ball
8 years, 3 months ago (2012-09-04 21:55:06 UTC) #2
hausner
I think the test would fail in checked mode. http://codereview.chromium.org/10918061/diff/1/runtime/tests/vm/dart/assert_with_type_test_or_cast_test.dart File runtime/tests/vm/dart/assert_with_type_test_or_cast_test.dart (right): http://codereview.chromium.org/10918061/diff/1/runtime/tests/vm/dart/assert_with_type_test_or_cast_test.dart#newcode23 runtime/tests/vm/dart/assert_with_type_test_or_cast_test.dart:23: ...
8 years, 3 months ago (2012-09-04 22:01:49 UTC) #3
hausner
8 years, 3 months ago (2012-09-04 22:10:12 UTC) #4
Ship it!

Powered by Google App Engine
This is Rietveld 408576698