Issue 10918047: First corelib cleanup patch after unification.

Issue 10918047: First corelib cleanup patch after unification. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)

Modified:
8 years, 3 months ago

Reviewers:
Johnni Winther, Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

First corelib cleanup patch after unification. Do not go through coreimpl for object implementation. Instead, use patching in core directly. This leads to error message issues in dart2js which I have patched up the best way I could find. R=ajohnsen@google.com,johnniwinther@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11784

Patch Set 1 #

Patch Set 2 : Remove bogus comment. #

Total comments: 6

Patch Set 3 : Address review comments. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -40 lines)			Patch
M	lib/_internal/libraries.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/dart2js.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/compiler/implementation/lib/core_patch.dart	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	lib/core/object.dart	View	1 2	1 chunk	+4 lines, -6 lines	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/object.dart	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/lib/lib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View		1 chunk	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

WOOT! STV! https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dart File lib/core/object.dart (right): https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dart#newcode11 lib/core/object.dart:11: operator ==(other) => this === other; Return ...

8 years, 3 months ago (2012-09-04 06:58:52 UTC) #3

Johnni Winther

lgtm https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dart File lib/core/object.dart (right): https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dart#newcode11 lib/core/object.dart:11: operator ==(other) => this === other; Must be ...

8 years, 3 months ago (2012-09-04 07:23:23 UTC) #4

Mads Ager (google)

8 years, 3 months ago (2012-09-04 07:27:05 UTC) #5

https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dart
File lib/core/object.dart (right):

https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dar...
lib/core/object.dart:11: operator ==(other) => this === other;
On 2012/09/04 06:58:52, Lasse Reichstein Nielsen wrote:
> Return type should be bool.

Done.

https://chromiumcodereview.appspot.com/10918047/diff/3001/lib/core/object.dar...
lib/core/object.dart:13: get dynamic() => this;
On 2012/09/04 06:58:52, Lasse Reichstein Nielsen wrote:
> Parentheses no longer needed.
> (But there's probably a largish cleanup for that in the future, so don't
bother
> fixing it now if you don't want to).

Done.

Expand Messages | Collapse Messages