Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 10918016: Removed handle creation and inlined two field index checks (Closed)

Created:
8 years, 3 months ago by Tom Ball
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed handle creation and inlined Instance::IsValidNativeIndex(). The Dromaeo dom core benchmark shows significant time spent in it, where ~half the time is spent creating a handle. Committed: https://code.google.com/p/dart/source/detail?r=11673

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M runtime/vm/object.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Ball
Removed handle creation and inlined Instance::IsValidNativeIndex() and Instance::IsValidFieldOffset(). The Dromaeo dom core benchmark shows significant ...
8 years, 3 months ago (2012-08-30 23:43:10 UTC) #1
Tom Ball
Removed handle creation and inlined Instance::IsValidNativeIndex() and Instance::IsValidFieldOffset(). The Dromaeo dom core benchmark shows significant ...
8 years, 3 months ago (2012-08-30 23:44:13 UTC) #2
Ivan Posva
8 years, 3 months ago (2012-08-31 01:01:46 UTC) #3
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698