Issue 10917223: Guard against allocation top overflow in ObjectArray_Allocate intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917223: Guard against allocation top overflow in ObjectArray_Allocate intrinsic. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Guard against allocation top overflow in ObjectArray_Allocate intrinsic. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12285

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove debugging changes #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
M	runtime/vm/constants_ia32.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/constants_x64.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 3 months ago (2012-09-12 21:26:34 UTC) #2

LGTM, once the CL is cleaned up and scrubbed from debugging code.

-Ivan

https://chromiumcodereview.appspot.com/10917223/diff/1/runtime/vm/intrinsifie...
File runtime/vm/intrinsifier_ia32.cc (right):

https://chromiumcodereview.appspot.com/10917223/diff/1/runtime/vm/intrinsifie...
runtime/vm/intrinsifier_ia32.cc:232: __ CompareClassId(EAX, kArrayCid, EDI);
?

Expand Messages | Collapse Messages