Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10917222: Move all the closure related fields in RawFunction into a new class (Closed)

Created:
8 years, 3 months ago by siva
Modified:
8 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Move all the closure related fields in RawFunction into a new class called RawClosureData Add a field called 'data_' in RawFunction which points to a RawClosureData object for closure functions, a signature class for signature functions or an implicit closure function if there is an implicit closure for a regular function. This ensures that we don't burn 5 fields in RawFunction for normal functions. The heap savings from this change on standalone dart is about 67k. After this change: New space (0k of 32768k) Old space (886k of 1024k) Code space (0k of 0k) Prior to this change: New space (0k of 32768k) Old space (953k of 1024k) Code space (0k of 0k) Committed: https://code.google.com/p/dart/source/detail?r=12290

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -25 lines) Patch
M vm/object.h View 1 5 chunks +40 lines, -6 lines 0 comments Download
M vm/object.cc View 8 chunks +143 lines, -13 lines 0 comments Download
M vm/raw_object.h View 3 chunks +20 lines, -6 lines 0 comments Download
M vm/raw_object.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M vm/raw_object_snapshot.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M vm/snapshot.h View 3 chunks +3 lines, -0 lines 0 comments Download
M vm/snapshot.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years, 3 months ago (2012-09-12 21:13:23 UTC) #1
regis
8 years, 3 months ago (2012-09-12 21:57:36 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698