Issue 10917187: First partial step at removing interfaces in libraries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917187: First partial step at removing interfaces in libraries. (Closed)

Created:
8 years, 3 months ago by bakster

Modified:
8 years, 3 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

First partial step at removing interfaces in libraries. - Changes interfaces without default implmenetations to abstract class. - Changed final fields in interfaces to getters. - Changed dart_analyzer to allow methods with empty bodies in abstract class. - Updated the co19 status file since two tests now are passing. Committed: https://code.google.com/p/dart/source/detail?r=12201

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -119 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/collection.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/duration.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	lib/core/expando.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/iterable.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/iterator.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/pattern.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/regexp.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/mirrors/mirrors.dart	View		21 chunks	+91 lines, -94 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages