Issue 10917170: Improve handling of built-in identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917170: Improve handling of built-in identifiers. (Closed)

Created:
8 years, 3 months ago by ahe

Modified:
8 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve handling of built-in identifiers. Committed: https://code.google.com/p/dart/source/detail?r=12132

Patch Set 1 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -177 lines)			Patch
M	dart/lib/compiler/implementation/compiler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/lib/js_helper.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/lib/compiler/implementation/resolver.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/keyword.dart	View	2 chunks	+55 lines, -95 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/listener.dart	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/parser.dart	View	22 chunks	+33 lines, -24 lines	1 comment	Download
M	dart/lib/compiler/implementation/scanner/scanner.dart	View	3 chunks	+31 lines, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/token.dart	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	dart/lib/compiler/implementation/tree/nodes.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	3 chunks	+19 lines, -34 lines	0 comments	Download
M	dart/tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/resolver_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/unparser_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 3 months ago (2012-09-10 16:20:53 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10917170/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/scanner/parser.dart (right):

https://chromiumcodereview.appspot.com/10917170/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/scanner/parser.dart:224: return
(keyword.isPseudo) || (value === 'Dynamic') || (value === 'void');
No need for parens in keyword.isPseudo

Expand Messages | Collapse Messages