Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Issue 10917100: Eliminate unnecessary factory constructors in abstract core classes (Closed)

Created:
8 years, 3 months ago by hausner
Modified:
8 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, Mads Ager (google), kasperl
Visibility:
Public.

Description

Eliminate unnecessary factory constructors in abstract core classes It is now a runtime error to instantiate an explicitly marked abstract class, so these factory constructors are no longer necessary. Committed: https://code.google.com/p/dart/source/detail?r=11965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M lib/core/comparable.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/core/function.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/core/hashable.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/core/num.dart View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
Aargh, forgot to send this out yesterday.
8 years, 3 months ago (2012-09-06 16:12:23 UTC) #1
regis
LGTM
8 years, 3 months ago (2012-09-06 16:14:24 UTC) #2
hausner
8 years, 3 months ago (2012-09-06 16:34:47 UTC) #3
Thank you.

Powered by Google App Engine
This is Rietveld 408576698