Issue 10917097: Move constants into their own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917097: Move constants into their own file. (Closed)

Created:
8 years, 3 months ago by floitsch

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move constants into their own file. Committed: https://code.google.com/p/dart/source/detail?r=11940

Patch Set 2 : Rebase (on top of copy of compile_time_constants.dart) #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1345 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View		1 chunk	+0 lines, -524 lines	0 comments	Download
M	lib/compiler/implementation/constants.dart	View	1	1 chunk	+0 lines, -821 lines	0 comments	Download
M	lib/compiler/implementation/leg.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10917097/diff/1/lib/compiler/implementation/constants.dart File lib/compiler/implementation/constants.dart (right): https://chromiumcodereview.appspot.com/10917097/diff/1/lib/compiler/implementation/constants.dart#newcode1 lib/compiler/implementation/constants.dart:1: // Copyright (c) 2012, the Dart project authors. ...

8 years, 3 months ago (2012-09-06 07:54:21 UTC) #3

floitsch

8 years, 3 months ago (2012-09-06 12:04:14 UTC) #4

https://chromiumcodereview.appspot.com/10917097/diff/1/lib/compiler/implement...
File lib/compiler/implementation/constants.dart (right):

https://chromiumcodereview.appspot.com/10917097/diff/1/lib/compiler/implement...
lib/compiler/implementation/constants.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/09/06 07:54:21, ngeoffray wrote:
> Maybe make an svn copy to make history easier to find.

done.

Expand Messages | Collapse Messages

Issue 10917097: Move constants into their own file. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase (on top of copy of compile_time_constants.dart) #

Messages