Issue 10917085: Revert "Remove classes Computation and BindInstr."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917085: Revert "Remove classes Computation and BindInstr." (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Remove classes Computation and BindInstr." This reverts svn revision 11868. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11869

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1845 lines, -1736 lines)			Patch
M	runtime/vm/flow_graph.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	8 chunks	+25 lines, -21 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	7 chunks	+24 lines, -24 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	67 chunks	+240 lines, -241 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	3 chunks	+12 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	3 chunks	+35 lines, -26 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	33 chunks	+284 lines, -264 lines	0 comments	Download
M	runtime/vm/il_printer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	28 chunks	+71 lines, -43 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	102 chunks	+755 lines, -629 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	41 chunks	+153 lines, -228 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	75 chunks	+110 lines, -106 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	75 chunks	+111 lines, -107 lines	0 comments	Download
M	runtime/vm/locations.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Reverted due to test failures in dart2js and the editor.

8 years, 3 months ago (2012-09-05 11:19:58 UTC) #1

lgtm

Expand Messages | Collapse Messages