Issue 10917070: Disallow legacy try-catch syntax.

Issue 10917070: Disallow legacy try-catch syntax. (Closed)

Created:
8 years, 3 months ago by kasperl

Modified:
8 years, 3 months ago

Reviewers:
karlklose, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disallow legacy try-catch syntax. R=karlklose@google.com,ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11807

Patch Set 2 : Improve testing. #

Total comments: 1

Patch Set 4 : Update co19 status. #

Patch Set 5 : Merge. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+624 lines, -317 lines)			Patch
M	lib/compiler/implementation/resolver.dart	View	1 2	2 chunks	+25 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View	1 2	1 chunk	+8 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3	11 chunks	+581 lines, -310 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/try_catch_syntax_test.dart	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kasperl

This cannot land without a major update to the co19-dart2js.status file, but I'd like to ...

8 years, 3 months ago (2012-09-04 07:50:21 UTC) #2

karlklose

Looks good so far. https://chromiumcodereview.appspot.com/10917070/diff/6/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10917070/diff/6/lib/compiler/implementation/resolver.dart#newcode1837 lib/compiler/implementation/resolver.dart:1837: // Check that the catch ...

8 years, 3 months ago (2012-09-04 10:27:02 UTC) #5

kasperl

I've added the necessary changes to co19-dart2js.status. PTAL.

8 years, 3 months ago (2012-09-04 12:07:06 UTC) #6

LGTM

Expand Messages | Collapse Messages