Issue 10917064: Throw an error if the ServerSocket host argument is invalid.

Issue 10917064: Throw an error if the ServerSocket host argument is invalid. (Closed)

Created:
8 years, 3 months ago by Anders Johnsen

Modified:
8 years, 3 months ago

Reviewers:
Søren Gjesse, Mads Ager (google), Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Throw an error if the ServerSocket host argument is invalid. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11769

Patch Set 2 : Use in_addr_t as s_addr type. #

Total comments: 2

Patch Set 3 : Check exception. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -5 lines)			Patch
M	runtime/bin/socket.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/socket.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/bin/socket_android.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/bin/socket_win.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	tests/standalone/io/socket_exception_test.dart	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10917064/diff/2001/tests/standalone/io/socket_exception_test.dart File tests/standalone/io/socket_exception_test.dart (right): https://chromiumcodereview.appspot.com/10917064/diff/2001/tests/standalone/io/socket_exception_test.dart#newcode33 tests/standalone/io/socket_exception_test.dart:33: Expect.throws(() => new ServerSocket("__INVALID_HOST__", PORT, 10)); Maybe do ...

8 years, 3 months ago (2012-09-03 13:56:44 UTC) #2

Anders Johnsen

Thank you, landing. https://chromiumcodereview.appspot.com/10917064/diff/2001/tests/standalone/io/socket_exception_test.dart File tests/standalone/io/socket_exception_test.dart (right): https://chromiumcodereview.appspot.com/10917064/diff/2001/tests/standalone/io/socket_exception_test.dart#newcode33 tests/standalone/io/socket_exception_test.dart:33: Expect.throws(() => new ServerSocket("__INVALID_HOST__", PORT, 10)); ...

8 years, 3 months ago (2012-09-03 14:34:38 UTC) #3

lgtm

Expand Messages | Collapse Messages