Issue 10917051: Deal with mock compilation in dart2js, which was working in the SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917051: Deal with mock compilation in dart2js, which was working in the SDK (Closed)

Created:
8 years, 3 months ago by dgrove

Modified:
8 years, 3 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Deal with mock compilation in dart2js, which was working in the SDK by reaching outside the SDK. Committed: https://code.google.com/p/dart/source/detail?r=11737

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/create_sdk.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

"lgtm" with comment https://chromiumcodereview.appspot.com/10917051/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10917051/diff/1/tools/create_sdk.py#newcode246 tools/create_sdk.py:246: unnecessary newline?

8 years, 3 months ago (2012-08-31 23:45:24 UTC) #4

"lgtm"

Expand Messages | Collapse Messages

Issue 10917051: Deal with mock compilation in dart2js, which was working in the SDK (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages