Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 10917005: Add explicit class checks: LoadVMField. (Closed)

Created:
8 years, 3 months ago by Florian Schneider
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add explicit class checks: LoadVMField. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=11598

Patch Set 1 #

Patch Set 2 : added missing check #

Patch Set 3 : removed now unused helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -102 lines) Patch
M runtime/vm/flow_graph_compiler_ia32.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
8 years, 3 months ago (2012-08-30 09:28:30 UTC) #1
Kevin Millikin (Google)
8 years, 3 months ago (2012-08-30 10:30:51 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698