Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 10916259: Enable wrapper-less browser tests on selenium. (Closed)

Created:
8 years, 3 months ago by ahe
Modified:
8 years, 3 months ago
Reviewers:
vsm, kasperl
CC:
reviews_dartlang.org, Emily Fortuna, gram, vsm
Visibility:
Public.

Description

Enable wrapper-less browser tests on selenium. Also fix bug 4631. Committed: https://code.google.com/p/dart/source/detail?r=12295

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M dart/pkg/unittest/test_controller.js View 4 chunks +14 lines, -8 lines 0 comments Download
M dart/tests/html/html.status View 3 chunks +0 lines, -3 lines 0 comments Download
M dart/tests/html/js_interop_1_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M dart/tools/testing/dart/test_suite.dart View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
ahe
8 years, 3 months ago (2012-09-12 11:04:24 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/10916259/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10916259/diff/1/dart/tools/testing/dart/test_suite.dart#newcode398 dart/tools/testing/dart/test_suite.dart:398: bool isWrappingRequired = configuration['compiler'] != 'dart2js'; w00t!
8 years, 3 months ago (2012-09-12 11:06:16 UTC) #2
ahe
Before: $ ./tools/test.py -mrelease -cdart2js -rff language Test configuration: dart2js_ff_release_ia32 [13:51 | 100% | + ...
8 years, 3 months ago (2012-09-12 12:07:10 UTC) #3
ngeoffray
On 2012/09/12 12:07:10, ahe wrote: > Before: > > $ ./tools/test.py -mrelease -cdart2js -rff language ...
8 years, 3 months ago (2012-09-13 06:43:41 UTC) #4
vsm
8 years, 3 months ago (2012-09-13 16:19:42 UTC) #5
lgtm and thanks!

Powered by Google App Engine
This is Rietveld 408576698