Support both new and old style package layouts.

Support both new and old style package layouts.

Update the tests to all use the new layout.

Committed: https://code.google.com/p/dart/source/detail?r=12224

[Bob Nystrom, 2012-09-08 01:22:27]

This also re-enables self links. If you don't want a circular symlink, just
update your package to the new lib/ layout and it will go away. :)

[nweiz, 2012-09-10 19:24:47]

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:301: if (isOldStyle) {
Shouldn't we print some sort of deprecation warning here? At some point we're
going to break the old package layout, and we want to give people plenty of
warning.

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:302: return createSymlink(from, to);
Style nit: avoid the extra indentation of the else block below.

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:306: // symlink at all.
It seems potentially confusing to users to just silently not create a symlink. I
can imagine a user being very puzzled because they've declared a dependency and
run "pub install" but the symlink still doesn't exist. We should probably either
print a warning or add a TODO to do so.

[devoncarew, 2012-09-10 19:41:07]

> This also re-enables self links. If you don't want a circular symlink, just
update your package to the new lib/ layout and it will go away. :)

My 0.02 would be to not support self links for older style packages. The
circular symlinks will still hork the editor.

Perhaps printing a deprecation warning whenever pub processes a package using
the old format? This will make people aware of the new format and help speed-up
the migration.

[danrubel, 2012-09-10 19:51:30]

On 2012/09/10 19:41:07, devoncarew wrote:
> > This also re-enables self links. If you don't want a circular symlink, just
> update your package to the new lib/ layout and it will go away. :)
> 
> My 0.02 would be to not support self links for older style packages. The
> circular symlinks will still hork the editor.
> 
> Perhaps printing a deprecation warning whenever pub processes a package using
> the old format? This will make people aware of the new format and help
speed-up
> the migration.

+1 ==> *not* adding back self links in the *old* format.
And encourage (strongly!) that folks move to the new format.

[Bob Nystrom, 2012-09-11 19:36:37]

On 2012/09/10 19:41:07, devoncarew wrote:
> > This also re-enables self links. If you don't want a circular symlink, just
> update your package to the new lib/ layout and it will go away. :)
> 
> My 0.02 would be to not support self links for older style packages. The
> circular symlinks will still hork the editor.

Done.

> 
> Perhaps printing a deprecation warning whenever pub processes a package using
> the old format? This will make people aware of the new format and help
speed-up
> the migration.

Done.

[Bob Nystrom, 2012-09-11 19:36:51]

On 2012/09/10 19:51:30, danrubel wrote:
> On 2012/09/10 19:41:07, devoncarew wrote:
> > > This also re-enables self links. If you don't want a circular symlink,
just
> > update your package to the new lib/ layout and it will go away. :)
> > 
> > My 0.02 would be to not support self links for older style packages. The
> > circular symlinks will still hork the editor.
> > 
> > Perhaps printing a deprecation warning whenever pub processes a package
using
> > the old format? This will make people aware of the new format and help
> speed-up
> > the migration.
> 
> +1 ==> *not* adding back self links in the *old* format.
> And encourage (strongly!) that folks move to the new format.

Done! :)

[Bob Nystrom, 2012-09-11 19:36:59]

Thanks!

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:301: if (isOldStyle) {
On 2012/09/10 19:24:47, nweiz wrote:
> Shouldn't we print some sort of deprecation warning here? At some point we're
> going to break the old package layout, and we want to give people plenty of
> warning.

I don't want to warn when a dependency has the old layout because that's often
outside of the user's control.

I did add a warning (and a test for it) if the entrypoint package itself uses
the old layout.

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:302: return createSymlink(from, to);
On 2012/09/10 19:24:47, nweiz wrote:
> Style nit: avoid the extra indentation of the else block below.

Done.

https://chromiumcodereview.appspot.com/10916190/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:306: // symlink at all.
On 2012/09/10 19:24:47, nweiz wrote:
> It seems potentially confusing to users to just silently not create a symlink.
I
> can imagine a user being very puzzled because they've declared a dependency
and
> run "pub install" but the symlink still doesn't exist. We should probably
either
> print a warning or add a TODO to do so.

Done. Prints warning.

[nweiz, 2012-09-11 21:07:47]

lgtm

https://chromiumcodereview.appspot.com/10916190/diff/5001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10916190/diff/5001/utils/pub/io.dart#n...
utils/pub/io.dart:295: Future<File> createPackageSymlink(String name, from, to,
Can't you infer the name from "from"?

[Bob Nystrom, 2012-09-11 21:39:00]

Thanks!

https://chromiumcodereview.appspot.com/10916190/diff/5001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10916190/diff/5001/utils/pub/io.dart#n...
utils/pub/io.dart:295: Future<File> createPackageSymlink(String name, from, to,
On 2012/09/11 21:07:47, nweiz wrote:
> Can't you infer the name from "from"?

I could, but every callsite knew the name so I figured it was simplest just to
pass it in.