Issue 10916185: New test case to ensure finalizers are not invoked on deleted handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916185: New test case to ensure finalizers are not invoked on deleted handles. (Closed)

Created:
8 years, 3 months ago by cshapiro

Modified:
8 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

New test case to ensure finalizers are not invoked on deleted handles. This also removes a needless allocation from the complementary test. Committed: https://code.google.com/p/dart/source/detail?r=12075

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -6 lines)			Patch
	M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+29 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM http://codereview.chromium.org/10916185/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): http://codereview.chromium.org/10916185/diff/1/runtime/vm/dart_api_impl_test.cc#newcode1452 runtime/vm/dart_api_impl_test.cc:1452: Dart_DeletePersistentHandle(weak_ref); Maybe add a comment that the finalizer ...

8 years, 3 months ago (2012-09-07 22:19:42 UTC) #2

cshapiro

8 years, 3 months ago (2012-09-07 22:32:21 UTC) #3

http://codereview.chromium.org/10916185/diff/1/runtime/vm/dart_api_impl_test.cc
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/10916185/diff/1/runtime/vm/dart_api_impl_test....
runtime/vm/dart_api_impl_test.cc:1452: Dart_DeletePersistentHandle(weak_ref);
Thanks, that is a good idea.  Done.

Expand Messages | Collapse Messages