Issue 10916172: num implements Comparable and Hashable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916172: num implements Comparable and Hashable. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

num implements Comparable and Hashable. Committed: https://code.google.com/p/dart/source/detail?r=12037

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+261 lines, -32 lines)			Patch
M	lib/compiler/implementation/elements/elements.dart	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/backend.dart	View	1	1 chunk	+14 lines, -14 lines	0 comments	Download
M	lib/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	4 chunks	+28 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/ssa/types.dart	View	1	2 chunks	+44 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
A	tests/compiler/dart2js_native/core_type_check_native_test.dart	View		1 chunk	+76 lines, -0 lines	0 comments	Download
A	tests/language/core_type_check_test.dart	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10916172/diff/2001/lib/compiler/implementation/js_backend/backend.dart File lib/compiler/implementation/js_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10916172/diff/2001/lib/compiler/implementation/js_backend/backend.dart#newcode706 lib/compiler/implementation/js_backend/backend.dart:706: if (nativeCheck) { Maybe use return ? : ...

8 years, 3 months ago (2012-09-07 13:03:46 UTC) #2

ngeoffray

8 years, 3 months ago (2012-09-07 14:06:36 UTC) #3

Thanks Kasper

https://chromiumcodereview.appspot.com/10916172/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/js_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10916172/diff/2001/lib/compiler/implem...
lib/compiler/implementation/js_backend/backend.dart:706: if (nativeCheck) {
On 2012/09/07 13:03:46, kasperl wrote:
> Maybe use return ? : in these cases in this file?

Done.

Expand Messages | Collapse Messages

Issue 10916172: num implements Comparable and Hashable. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages