Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 10916119: Allow test context to have multiple true and false branch slots. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow test context to have multiple true and false branch slots. Implement special handling for && and || in the test context to eliminate materialization of intermediate boolean values. R=kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -57 lines) Patch
M runtime/vm/flow_graph_builder.h View 2 chunks +18 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 13 chunks +116 lines, -45 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Google)
8 years, 3 months ago (2012-09-05 15:51:10 UTC) #1
Kevin Millikin (Google)
8 years, 3 months ago (2012-09-05 17:30:53 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698