Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 10916111: Change backlog on http server listen from 5 to 128. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)
Modified:
8 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change backlog on http server listen from 5 to 128. 5 simultaneously connecting clients seems like very little. This also fixes an http client test on Mac. If the backlog is too small a connection can be dropped again before it is accepted and the client will get a "broken pipe" or "connection reset" error. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/bin/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 3 months ago (2012-09-05 09:34:42 UTC) #1
Søren Gjesse
lgtm Should we perhaps add some additional comments on backlog in the documentation?
8 years, 3 months ago (2012-09-05 10:32:36 UTC) #2
Mads Ager (google)
8 years, 3 months ago (2012-09-05 10:42:30 UTC) #3
On 2012/09/05 10:32:36, Søren Gjesse wrote:
> lgtm
> 
> Should we perhaps add some additional comments on backlog in the
documentation?

We could. I'm not sure what to put there though. The current documentation
refers to the OS listen setup. I think that is probably as detailed as we want
to get so we don't have to write a lot about how various OS implementations of
listen differ.

Powered by Google App Engine
This is Rietveld 408576698