Issue 10916090: Support immediate operands for array bounds checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916090: Support immediate operands for array bounds checks. (Closed)

Created:
8 years, 3 months ago by Florian Schneider

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support immediate operands for array bounds checks. Committed: https://code.google.com/p/dart/source/detail?r=11824

Patch Set 2 : addressed comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -44 lines)			Patch
M	runtime/vm/intermediate_language_ia32.cc	View	1	4 chunks	+27 lines, -30 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+25 lines, -14 lines	0 comments	Download
M	runtime/vm/locations.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm with a comment https://chromiumcodereview.appspot.com/10916090/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10916090/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode2235 runtime/vm/intermediate_language_ia32.cc:2235: locs->set_in(1, Location::Constant(constant_index->value())); I recommend creating ...

8 years, 3 months ago (2012-09-04 14:38:41 UTC) #2

Addressed comment.

Expand Messages | Collapse Messages

Issue 10916090: Support immediate operands for array bounds checks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages