Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 10916082: Make register allocator to disregard constant computation with no uses. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make register allocator to disregard constant computation with no uses. Inline constant values into environments, instead of creating a use of the constant definition. Change BinarySmiOpComp code template to allow inline constant uses for the right hand side. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -10 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 5 chunks +20 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 4 chunks +86 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 4 chunks +88 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Google)
8 years, 3 months ago (2012-09-03 19:47:10 UTC) #1
Florian Schneider
8 years, 3 months ago (2012-09-04 09:43:59 UTC) #2
LGTM.

Make sure that the new instructions are also handled in the disassembler.

Powered by Google App Engine
This is Rietveld 408576698