Issue 10916079: Allow access to super fields inside a closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916079: Allow access to super fields inside a closure. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow access to super fields inside a closure. Committed: https://code.google.com/p/dart/source/detail?r=11786

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -5 lines)			Patch
M	lib/compiler/implementation/closure.dart	View	1	3 chunks	+8 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/js_backend/emitter.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download
A	tests/language/closure_with_super_field_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://chromiumcodereview.appspot.com/10916079/diff/7/lib/compiler/implementation/closure.dart File lib/compiler/implementation/closure.dart (right): https://chromiumcodereview.appspot.com/10916079/diff/7/lib/compiler/implementation/closure.dart#newcode79 lib/compiler/implementation/closure.dart:79: Element originalElement; methodElement ? It is not really ...

8 years, 3 months ago (2012-09-03 16:59:16 UTC) #2

ngeoffray

8 years, 3 months ago (2012-09-04 07:06:09 UTC) #4

Thanks Kasper and Florian

https://chromiumcodereview.appspot.com/10916079/diff/7/lib/compiler/implement...
File lib/compiler/implementation/closure.dart (right):

https://chromiumcodereview.appspot.com/10916079/diff/7/lib/compiler/implement...
lib/compiler/implementation/closure.dart:79: Element originalElement;
On 2012/09/03 16:59:16, floitsch wrote:
> methodElement ?
> It is not really the "original".

Done.

Expand Messages | Collapse Messages

Issue 10916079: Allow access to super fields inside a closure. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages