Throw AbstractClassInstantiationError if an abstract class is instantiated

Throw AbstractClassInstantiationError if an abstract class is instantiated

This is the second try to my previous attempt to implement the
new abstract class handling. Instead of a compile-time error,
the VM now throws an AbstractClassInstantiationError at runtime
if an abstract class is instantiated. Added the new error class
to the core library.

For now I'm still using the rule that a class is abstract if it is explicitly
marked as abstract, or if it defines a new abstract method.
Committed: https://code.google.com/p/dart/source/detail?r=11708

[hausner, 2012-08-30 23:40:14]

I wouldn't want you to be idle while you wait for me to review your change :)

[regis, 2012-08-31 01:16:48]

LGTM with comments and still a bit confused why most of your tests are marked as
compile-time error rather than runtime error.

> I wouldn't want you to be idle while you wait for me to review your change :)
You sent it a bit too late to prevent me from idling up Twin Peaks and back :-)

-- Regis

http://codereview.chromium.org/10916039/diff/1/runtime/lib/error.cc
File runtime/lib/error.cc (right):

http://codereview.chromium.org/10916039/diff/1/runtime/lib/error.cc#newcode106
runtime/lib/error.cc:106: 
Missing blank line.
Also, missing comment documenting arguments, as all other runtime entries do.

http://codereview.chromium.org/10916039/diff/1/runtime/lib/error.cc#newcode133
runtime/lib/error.cc:133: 
Missing blank line.

http://codereview.chromium.org/10916039/diff/1/runtime/vm/bootstrap_natives.h
File runtime/vm/bootstrap_natives.h (right):

http://codereview.chromium.org/10916039/diff/1/runtime/vm/bootstrap_natives.h...
runtime/vm/bootstrap_natives.h:204: #define DECLARE_BOOTSTRAP_NATIVE(name,
ignored)         \
While you are here, you could move this backslash to column 80.

http://codereview.chromium.org/10916039/diff/1/tests/language/abstract_factor...
File tests/language/abstract_factory_constructor_test.dart (left):

http://codereview.chromium.org/10916039/diff/1/tests/language/abstract_factor...
tests/language/abstract_factory_constructor_test.dart:28: }
Why not turn this test into a negative one instead of deleting it?
/// 01: runtime error

http://codereview.chromium.org/10916039/diff/1/tests/language/get_set_syntax_...
File tests/language/get_set_syntax_test.dart (right):

http://codereview.chromium.org/10916039/diff/1/tests/language/get_set_syntax_...
tests/language/get_set_syntax_test.dart:48: new C1();           /// 16:
compile-time error
I thought it was now a runtime error?

http://codereview.chromium.org/10916039/diff/1/tests/language/interface_test....
File tests/language/interface_test.dart (left):

http://codereview.chromium.org/10916039/diff/1/tests/language/interface_test....
tests/language/interface_test.dart:40: var o = new Bi(); /// static type warning
/// runtime error?

[hausner, 2012-08-31 18:06:52]

Thanks for the review!

http://codereview.chromium.org/10916039/diff/1/runtime/lib/error.cc
File runtime/lib/error.cc (right):

http://codereview.chromium.org/10916039/diff/1/runtime/lib/error.cc#newcode106
runtime/lib/error.cc:106: 
On 2012/08/31 01:16:48, regis wrote:
> Missing blank line.
> Also, missing comment documenting arguments, as all other runtime entries do. 

Done.

http://codereview.chromium.org/10916039/diff/1/runtime/lib/error.cc#newcode133
runtime/lib/error.cc:133: 
On 2012/08/31 01:16:48, regis wrote:
> Missing blank line.

Done.

http://codereview.chromium.org/10916039/diff/1/runtime/vm/bootstrap_natives.h
File runtime/vm/bootstrap_natives.h (right):

http://codereview.chromium.org/10916039/diff/1/runtime/vm/bootstrap_natives.h...
runtime/vm/bootstrap_natives.h:204: #define DECLARE_BOOTSTRAP_NATIVE(name,
ignored)         \
On 2012/08/31 01:16:48, regis wrote:
> While you are here, you could move this backslash to column 80.

Done.

http://codereview.chromium.org/10916039/diff/1/tests/language/abstract_factor...
File tests/language/abstract_factory_constructor_test.dart (left):

http://codereview.chromium.org/10916039/diff/1/tests/language/abstract_factor...
tests/language/abstract_factory_constructor_test.dart:28: }
On 2012/08/31 01:16:48, regis wrote:
> Why not turn this test into a negative one instead of deleting it?
> /// 01: runtime error

We have other tests that make sure we cannot instantiate an abstract class.  But
I agree that the static type warning may still be a valuable test case.

http://codereview.chromium.org/10916039/diff/1/tests/language/get_set_syntax_...
File tests/language/get_set_syntax_test.dart (right):

http://codereview.chromium.org/10916039/diff/1/tests/language/get_set_syntax_...
tests/language/get_set_syntax_test.dart:48: new C1();           /// 16:
compile-time error
On 2012/08/31 01:16:48, regis wrote:
> I thought it was now a runtime error?

Correct. My oversight.

http://codereview.chromium.org/10916039/diff/1/tests/language/interface_test....
File tests/language/interface_test.dart (left):

http://codereview.chromium.org/10916039/diff/1/tests/language/interface_test....
tests/language/interface_test.dart:40: var o = new Bi(); /// static type warning
On 2012/08/31 01:16:48, regis wrote:
> /// runtime error?

Revived the test. Done.