Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10916035: Reapply dom_deprecated removal with non-editor breaking change. (Closed)

Created:
8 years, 3 months ago by Emily Fortuna
Modified:
8 years, 3 months ago
Reviewers:
dgrove, pquitslund
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply dom_deprecated removal with non-editor breaking change. Committed: https://code.google.com/p/dart/source/detail?r=11715

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13369 lines) Patch
M compiler/api.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/_internal/libraries.dart View 1 1 chunk +0 lines, -7 lines 0 comments Download
M lib/compiler/implementation/apiimpl.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_any.config View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_dart2js.config View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_dartium.config View 1 1 chunk +0 lines, -1 line 0 comments Download
D pkg/unittest/dom_config.dart View 1 1 chunk +0 lines, -46 lines 0 comments Download
M pkg/unittest/unittest.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
D samples/matrix/float32.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download
D samples/matrix/matrix4.dart View 1 1 chunk +0 lines, -369 lines 0 comments Download
D samples/matrix/matrix_client.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
D samples/matrix/matrix_server.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
D samples/swarm/htmlconverter.py View 1 1 chunk +0 lines, -557 lines 0 comments Download
D samples/swarm/htmlconverter_test.py View 1 1 chunk +0 lines, -414 lines 0 comments Download
M samples/third_party/dromaeo/Suites.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M samples/third_party/dromaeo/tests/RunnerSuite.dart View 1 1 chunk +1 line, -7 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-attr-dom.dart View 1 1 chunk +0 lines, -35 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-attr-dom.html View 1 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify-dom.dart View 1 1 chunk +0 lines, -69 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify-dom.html View 1 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query-dom.dart View 1 1 chunk +0 lines, -104 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query-dom.html View 1 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse-dom.dart View 1 1 chunk +0 lines, -89 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse-dom.html View 1 1 chunk +0 lines, -2900 lines 0 comments Download
M tests/compiler/dart2js_foreign/native_call_arity1_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_call_arity3_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Dan -- this CL is identical to my original one with the exception that I've ...
8 years, 3 months ago (2012-08-30 23:00:41 UTC) #1
dgrove
lgtm
8 years, 3 months ago (2012-08-30 23:03:51 UTC) #2
pquitslund
8 years, 3 months ago (2012-08-31 18:00:48 UTC) #3
LGTM.  Let 'er rip!

Powered by Google App Engine
This is Rietveld 408576698