Issue 10916015: Parsing dates with format that's just month or day will fail on certain days

Issue 10916015: Parsing dates with format that's just month or day will fail on certain days (Closed)

Created:
8 years, 3 months ago by Alan Knight

Modified:
8 years, 3 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Parsing dates with format that's just month or day will fail on certain days Committed: https://code.google.com/p/dart/source/detail?r=11636

Patch Set 3 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -15 lines)			Patch
M	pkg/intl/lib/date_format_helpers.dart	View	1 2	2 chunks	+6 lines, -11 lines	1 comment	Download
M	pkg/intl/test/date_time_format_test.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/pkg.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/10916015/diff/3001/pkg/intl/lib/date_format_helpers.dart File pkg/intl/lib/date_format_helpers.dart (right): https://chromiumcodereview.appspot.com/10916015/diff/3001/pkg/intl/lib/date_format_helpers.dart#newcode32 pkg/intl/lib/date_format_helpers.dart:32: * use the "Epoch" (January 1, 1970), since the ...

8 years, 3 months ago (2012-08-30 17:44:03 UTC) #3

Alan Knight

PTAL https://chromiumcodereview.appspot.com/10916015/diff/3001/pkg/intl/lib/date_format_helpers.dart File pkg/intl/lib/date_format_helpers.dart (right): https://chromiumcodereview.appspot.com/10916015/diff/3001/pkg/intl/lib/date_format_helpers.dart#newcode32 pkg/intl/lib/date_format_helpers.dart:32: * use the "Epoch" (January 1, 1970), since ...

8 years, 3 months ago (2012-08-30 17:50:40 UTC) #4

Anton Muhin

8 years, 3 months ago (2012-08-30 17:52:11 UTC) #5

LGTM

https://chromiumcodereview.appspot.com/10916015/diff/2002/pkg/intl/lib/date_f...
File pkg/intl/lib/date_format_helpers.dart (right):

https://chromiumcodereview.appspot.com/10916015/diff/2002/pkg/intl/lib/date_f...
pkg/intl/lib/date_format_helpers.dart:36: Date asDate() {
nit: you may prefer arrow syntax now.

Expand Messages | Collapse Messages