Issue 10915234: Mark phi as producing a smi value if it is dominated by SmiChecks over its operands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10915234: Mark phi as producing a smi value if it is dominated by SmiChecks over its operands. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark phi as producing a smi value if it is dominated by SmiChecks over its operands. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12273

Patch Set 1 #

Patch Set 2 : Improve handling of phi-cycles. #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -4 lines)			Patch
M	runtime/vm/compiler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+136 lines, -0 lines	2 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years, 3 months ago (2012-09-12 17:13:11 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10915234/diff/3001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10915234/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_optimizer.cc:1037: worklist_.RemoveLast();
Add ASSERT(in_worklist_->Contains(phi->ssa_temp_index());

https://chromiumcodereview.appspot.com/10915234/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_optimizer.cc:1058: if (IsSmiPhi(phi)) {
Maybe assert

ASSERT(phi->GetPropagatedCid() != kSmiCid) here.

Expand Messages | Collapse Messages