Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 10915171: Don't report 'no such method' if class defines 'noSuchMethod' (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't report 'no such method' if class defines 'noSuchMethod' R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12121

Patch Set 1 #

Patch Set 2 : Add preference #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -31 lines) Patch
M compiler/java/com/google/dart/compiler/CommandLineOptions.java View 1 1 chunk +8 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 3 chunks +29 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java View 4 chunks +3 lines, -19 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 4 chunks +15 lines, -9 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 1 chunk +82 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java View 1 1 chunk +7 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java View 1 1 chunk +7 lines, -0 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/DartAnalysisPreferencePage.java View 1 4 chunks +12 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.properties View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
8 years, 3 months ago (2012-09-10 13:15:08 UTC) #1
Brian Wilkerson
LGTM as long as this is still spec compliant. I don't have access to the ...
8 years, 3 months ago (2012-09-10 13:43:30 UTC) #2
scheglov
PTAL
8 years, 3 months ago (2012-09-10 14:52:38 UTC) #3
Brian Wilkerson
LGTM https://chromiumcodereview.appspot.com/10915171/diff/4001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java (right): https://chromiumcodereview.appspot.com/10915171/diff/4001/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java#newcode486 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:486: false); Unless I'm confused, this is the inverse ...
8 years, 3 months ago (2012-09-10 15:22:56 UTC) #4
scheglov
8 years, 3 months ago (2012-09-10 15:40:05 UTC) #5
https://chromiumcodereview.appspot.com/10915171/diff/4001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java
(right):

https://chromiumcodereview.appspot.com/10915171/diff/4001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java:486:
false);
On 2012/09/10 15:22:56, Brian Wilkerson wrote:
> Unless I'm confused, this is the inverse of the default for the compiler
> settings. Was that intentional (command line reports errors, editor doesn't)?

Yes, this is correct.
Do according Spec for command line, do what is logical (as it seems everyone
think) in Editor.

Powered by Google App Engine
This is Rietveld 408576698